Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: mmozeiko.wcap version 2024.10.18 #200054

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

New version: mmozeiko.wcap version 2024.10.18 #200054

wants to merge 3 commits into from
+60 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 20, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Dec 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 20, 2024
@Dragon1573 @DuckDuckStudio
Apply suggestions from code review
37232a9 
- Correction of `InstallerSha256` for `arm64` installer

Co-authored-by: 鸭鸭「カモ」 <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. labels Dec 20, 2024
@wingetbot
Copy link
Collaborator

=== manifests\m\mmozeiko\wcap\2024.10.18 ===
Missing Properties value based on version 2022.11.06:
ReleaseNotesUrl

@wingetbot wingetbot added Manifest-Metadata-Consistency New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Dec 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 20, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Domain Needs-Author-Feedback This needs a response from the author. labels Dec 20, 2024
@stephengillie
Copy link
Collaborator

HI @Dragon1573,

Is this intentional?

=== manifests\m\mmozeiko\wcap\2024.10.18 ===
Missing Properties value based on version 2022.11.06:
ReleaseNotesUrl

@DuckDuckStudio DuckDuckStudio mentioned this pull request Dec 21, 2024
Open
@DuckDuckStudio
Copy link
Contributor

Tip

The ReleaseNotesUrl for the previous version no longer seems to be available.
We seem to be able to replace the ReleaseNotesUrl with: https://github.com/mmozeiko/wcap/blob/main/CHANGELOG.md#20241018

@Dragon1573
Apply suggestions from code review
2cc67a2 
- Add `ReleaseNotesUrl` back
auto-merge was automatically disabled December 21, 2024 12:02

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Manifest-Metadata-Consistency New-Manifest labels Dec 21, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain labels Dec 21, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hello @Dragon1573,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckDuckStudio DuckDuckStudio DuckDuckStudio approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Dragon1573 Dragon1573

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. New-Manifest Validation-Domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: mmozeiko.wcap
4 participants
@Dragon1573 @wingetbot @stephengillie @DuckDuckStudio