Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGs are not isolated in notebooks #173491

Closed
8uurg opened this issue Feb 5, 2023 · 8 comments
Closed

SVGs are not isolated in notebooks #173491

8uurg opened this issue Feb 5, 2023 · 8 comments
Assignees
@rebornix @mjbvz
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities notebook under-discussion Issue is under discussion for relevance, priority, approach
Milestone
Backlog Candidates

Comments

@8uurg
Copy link

8uurg commented Feb 5, 2023

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.75.0 (system setup)
Commit: e2816fe
Date: 2023-02-01T15:23:45.584Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: No

Steps to Reproduce:

  1. Open a notebook containing an SVG file that that has colliding symbol ids. See for example CarioPlot with vertex labels has plots interact within a Jupyter Notebook in VSCode igraph/python-igraph#638
  2. Issue occurs for both the built-in and the jupyter-extension svg renderer - isolate tag provided is ignored in both cases.
@sbatten sbatten assigned DonJayamanne and unassigned sbatten Feb 18, 2023
@DonJayamanne DonJayamanne assigned mjbvz and unassigned DonJayamanne Feb 22, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 22, 2023

@DonJayamanne Does jupyter always embed svgs inside of iframes?

@mjbvz mjbvz added under-discussion Issue is under discussion for relevance, priority, approach notebook labels Feb 27, 2023
@8uurg
Copy link
Author

8uurg commented Mar 3, 2023

One thing I should have noted is that in the specific case listed above the library specifically attaches the metadata tag 'isolated': True as part of the repr function (igraph/python-igraph/pull/148), which causes jupyter to isolate it within an iframe. vscode ignores this tag.

@DonJayamanne
Copy link
Contributor

@mjbvz sorry I missed this, no in Jupyter Notebooks, they are embedded within the same DOM.

@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Apr 24, 2023
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Apr 24, 2023
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jun 24, 2023
@DonJayamanne DonJayamanne reopened this Jun 24, 2023
@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2023
@DonJayamanne DonJayamanne reopened this Jun 25, 2023
@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities notebook under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
Backlog Candidates
Development

No branches or pull requests
6 participants
@rebornix @DonJayamanne @8uurg @sbatten @mjbvz @vscodenpa