Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably unused ring buffers for Prometheus Config #4486

Closed
nowkarol opened this issue Dec 9, 2023 · 1 comment
Closed

Probably unused ring buffers for Prometheus Config #4486

nowkarol opened this issue Dec 9, 2023 · 1 comment
Labels
invalid An issue that we don't feel is valid

Comments

@nowkarol
Copy link

nowkarol commented Dec 9, 2023

Describe the bug
Hi, I've got question (not sure if it is a bug) regarding ring buffers in AbstractTimeWindowHistogram and TimeWindowMax. I use them with Prometheus so my DistributionStatisticConfig consists of 1 minute expiry and buffer length of 3. I have some doubts about using 3 histograms.

As far as I can tell values are recorded in each one of them. Reads are done only from currently selected. Every 20 seconds during histogram interaction previous one is cleared same as accumulated histogram. I cannot see any usage of other two histograms.

So my question is: how (for Prometheus) are used two other histograms? Is this oversight and PrometheusMeterRegistry should override bufferLength to 1?

Additional context
This task and this one are concerned with TimeWindowMax. @shakuzen answer is correct but don't point why it behaves like this, it is also little confusing regarding that comment - it doesn't mention buffer size dependency.

@nowkarol
Copy link
Author

nowkarol commented Dec 9, 2023

Sorry for spam, took me a while to understand that it's done to group (and evict) values in smaller intervals than expiry time

@nowkarol nowkarol closed this as completed Dec 9, 2023
@jonatan-ivanov jonatan-ivanov closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2023
@jonatan-ivanov jonatan-ivanov added invalid An issue that we don't feel is valid and removed waiting-for-triage labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid An issue that we don't feel is valid
Projects
None yet
Development

No branches or pull requests

2 participants