-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Released version prints 'Hello World' #4
Comments
Hey @smoak. Yes, you are correct. I released 0.0.0 to setup the package, but never released a proper first version. I got caught up with other things and this fell to the side. Even though I'm not happy with the current state, releasing something is probably a good idea. To be honest, I doubted anyone would find / want to use the library... |
Not exactly on-topic for this issue, but I forked this repo and added objects for game status, schedule, and season before deciding it was overkill for my purposes and writing a very lightweight wrapper. I don't think I even checked in my changes to my fork, but I can do that and submit a pull request. You'll probably want to merge to a dev branch and test everything out before merging to master and releasing, but you are free to do whatever you wish with the pull request. |
@toddrob99 thanks. Yeah, I'm taking a new look at the library. I would definitely like to check out your changes / updates. If I revamp this library, which I may, I'll probably end up refactoring the code. So it may take me some manual effort to incorporate your changes, but they're very welcome! |
Submitted #7 I tried to follow your coding style the best I could. |
Issue: The 0.0.0 released version on pypi just prints 'Hello World':
$ cat site-packages/nhl/__init__.py print("Hello world")
Suggestion: Release a new version (perhaps 0.0.1?) with the latest code.
The text was updated successfully, but these errors were encountered: