Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amqps:// scheme in Broker URL breaks Broker Tab #1369

Open
DrMeers opened this issue Apr 12, 2024 · 6 comments
Open

amqps:// scheme in Broker URL breaks Broker Tab #1369

DrMeers opened this issue Apr 12, 2024 · 6 comments
Labels

Comments

@DrMeers
Copy link

DrMeers commented Apr 12, 2024

Running flower via celery --broker=amqps://... (as provided by CloudAMQP plugin on Heroku, for example) means when you check the Broker tab in the Flower dashboard you just see the error message 'amqp' broker is not supported which is confusing to say the least:

Screenshot 2024-04-12 at 20 45 28

It seems that simply adding a check for amqps in utils/broker.py would allow this to work correctly; currently it raises NotImplementedError

if scheme == 'amqp':
    return RabbitMQ(broker_url, *args, **kwargs)
elif scheme == 'redis':
    return Redis(broker_url, *args, **kwargs)
elif scheme == 'rediss':
    return RedisSsl(broker_url, *args, **kwargs)
elif scheme == 'redis+socket':
    return RedisSocket(broker_url, *args, **kwargs)
elif scheme == 'sentinel':
    return RedisSentinel(broker_url, *args, **kwargs)
else:
    raise NotImplementedError

As far as I can see, the same RabbitMQ class should suffice and already seems to support https?

@DrMeers DrMeers added the bug label Apr 12, 2024
DrMeers added a commit to DrMeers/flower that referenced this issue Apr 12, 2024
@7C-habib
Copy link

@DrMeers any update as to when this will be merged in master.

@EwertonDCSilv
Copy link

EwertonDCSilv commented Apr 24, 2024

@mher alguma novidade sobre o tema ? Tenho o mesmo problema usando o RabbitMQ

@EwertonDCSilv
Copy link

Segue o docker-compose.yaml que defini:

  celery_flower:
    container_name: "celery_flower"
    environment:
      - PYTHONPATH=/app
      - CELERY_BROKER_URL=amqps://guest:guest@rabbitmq:5672/vhost
      - CELERY_RESULT_BACKEND=redis://redis:6379/0
      - FLOWER_PORT=8888
    image: mher/flower:latest
    volumes:
      - .:/app
    command: celery flower --port=8888
    ports:
      - 8888:8888

the-witch-king added a commit to the-witch-king/flower that referenced this issue Apr 26, 2024
Issue here: mher#1369

Flower does not take into account the `BROKER_API` config setting right
now if the scheme is set to `amqps`. It errors.

This seems like it should not be the case, as there is no change
required for the RabbitMQ API to work, regardless of amqp or amqps.
the-witch-king added a commit to the-witch-king/flower that referenced this issue Apr 30, 2024
Issue here: mher#1369

Flower does not take into account the `BROKER_API` config setting right
now if the scheme is set to `amqps`. It errors.

This seems like it should not be the case, as there is no change
required for the RabbitMQ API to work, regardless of amqp or amqps.
@the-witch-king
Copy link

Is there any update on this?

@schodge
Copy link

schodge commented Jul 10, 2024

This is also a problem in my deploy, is there a workaround? Using RabbitMQ on AWS

@claudinoac
Copy link

We're having the same problem using RabbitMQ over SSL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants