Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled down order in simulated broker mentioned but not implemented? #382

Open
pmkenny1234 opened this issue Jan 11, 2023 · 0 comments
Open

Comments

@pmkenny1234
Copy link

On line 584 of simulated_broker.py (in _execute_order()), there is a comment about scaling down the order if there isn't available cash. However, a few lines later scaled_quantity is set to just order.quantity. Is it desired that the scaling actually happen? I'm definitely seeing a negative cash balance commonly when running simulations, which makes sense since orders may be placed well before they're actually filled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant