Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] CI verification of fixup-mountpoints #112

Open
marmistrz opened this issue Aug 1, 2017 · 2 comments
Open

[Idea] CI verification of fixup-mountpoints #112

marmistrz opened this issue Aug 1, 2017 · 2 comments

Comments

@marmistrz
Copy link
Contributor

marmistrz commented Aug 1, 2017

It's more than easy to make a small mistake in fixup-mountpoints (forget the trailing ;;, for instance). Thus I'd suggest using some CI service [1] [2] to validate its correctness using shellcheck. [3] There's an official Docker image for shellcheck CI [4]

Similarly, pylint could be used to verify assert-device (please keep in mind that pylint is sometimes overzealous). Still, the main concern is fixup-mountpoints, because it's the one most PRs target.

[1] https://github.com/ligurio/Continuous-Integration-services/blob/master/continuous-integration-services-list.md
[2] https://github.com/marketplace/category/continuous-integration
[3] https://github.com/koalaman/shellcheck
[4] https://hub.docker.com/r/koalaman/shellcheck/

@sledges
Copy link
Contributor

sledges commented Aug 1, 2017

Thanks for these useful insights, I've briefly checked it out, but a couple of those I tried require an account to be registered in 3rd party websites, would you know a shellcheck CI working more out-of-the-boxy? :)

@marmistrz
Copy link
Contributor Author

Shellcheck itself doesn't provide any CI service AFAIK. It's just a Haskell program. GitLab provides an integrated CI service for your repo but GitHub doesn't.

On GitHub you have to register with your GitHub account for a third-party CI service which integrates with GitHub. If the project is public, you could possibly use another account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants