Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using zoomSnap and zoomDelta, a seamline is present #64

Open
mejackreed opened this issue Oct 16, 2017 · 8 comments
Open

When using zoomSnap and zoomDelta, a seamline is present #64

mejackreed opened this issue Oct 16, 2017 · 8 comments
Labels

Comments

@mejackreed
Copy link
Owner

mejackreed commented Oct 16, 2017

Tracking upstream here: Leaflet/Leaflet#3575

The fix described in https://github.com/Leaflet/Leaflet.TileLayer.NoGap unfortunately does not work.

@mejackreed mejackreed added the bug label Oct 16, 2017
@mejackreed
Copy link
Owner Author

I've also noticed that some tile sources work as expected (no seam) while others present the seam:

fractional

No seam

https://dzkimgs.l.u-tokyo.ac.jp/iiifimgs/zuzoubu/12b02/0001-0025.tif/info.json

Seam

http://codh.rois.ac.jp/pmjt/iiif/200014778/200014778_00023.tif/info.json

@2SC1815J
Copy link
Contributor

No seam
https://dzkimgs.l.u-tokyo.ac.jp/iiifimgs/zuzoubu/12b02/0001-0025.tif/info.json

It looks inconspicuous because it is the same color.
You can see some seam lines on the captured image.
sat_zuzoubu

And how about this info.json ? (the bottom of the list shown below)
https://dzkimgs.l.u-tokyo.ac.jp/iiifimgs/zuzoubu/02/0002.tif/info.json
http://rawgit.com/2SC1815J/19219fe9f54592df5e214074f5579ab5/raw/

@mejackreed
Copy link
Owner Author

Thanks for the comment. I see the seam in your video, but still cannot find it locally.

However, on https://dzkimgs.l.u-tokyo.ac.jp/iiifimgs/zuzoubu/02/0002.tif/info.json the seam is present for me.

@2SC1815J
Copy link
Contributor

2SC1815J commented Oct 19, 2017

Here is a pure Leaflet 1.2.0 example (without Leaflet-IIIF) and you may see the seam on it.
http://leafletjs.com/examples/zoom-levels/example-delta.html
leaflet_zoom_level_0 75
leaflet_zoom_level_1 75
(These images are captured from the example on Firefox 56.0.1.)

So, it might be a problem of Leaflet itself, not of Leaflet-IIIF.
It seems that the Leaflet/Leaflet#3575 has not been fixed yet.

@IMMSPgisgroup
Copy link

I see same bug as in previous post on Firefox Quantum.

@IMMSPgisgroup
Copy link

I don't see this bug on Google Chrome or Microsoft Edge, only on Firefox.

@mejackreed
Copy link
Owner Author

I've created an example we can use to test: https://bl.ocks.org/mejackreed/bec44e64a18dfcb5bd89d691a2f86a55

@2SC1815J
Copy link
Contributor

2SC1815J commented Apr 3, 2018

Thank you for creating a test bench.
The attached images are captured with Firefox 59.0.2 (top) and Google Chrome 65.0.3325.181 (bottom).
Firefox 59.0.2
Chrome 65.0.3325.181
Unfortunately, with Chrome is less noticeable than with Firefox, but the seams are still visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants