Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest Adding a Player Selection #1084

Open
Moango opened this issue Oct 17, 2024 · 1 comment
Open

Suggest Adding a Player Selection #1084

Moango opened this issue Oct 17, 2024 · 1 comment
Labels
frontend Frontend issues

Comments

@Moango
Copy link

Moango commented Oct 17, 2024

Hello! I've noticed that the current video player interface is not very appealing and does not support screen rotation. I suggest considering a replacement with a player like Plyr, which could enhance user experience and provide better functionality. Thank you for your efforts, and I hope this suggestion can be helpful to the project!

@mgogoulos
Copy link
Contributor

Hi, interesting topic, as I recently tried to upgrade videojs from 7.x to 8.x and there are backwards incompatible changes in 8.x that make the upgrade hard. It didn't finish for me. There is a lot of code that would need to be rewriten, so a migration to something else that is easier to maintain and integrate looks appealing. However, since the video player is a core part of the system, we first need to answer the following questions:

  • Does Plyr support HLS out of the box? It seems not, and this is a crucial feature for modern video.
  • Does Plyr support chapters?
  • How hard/easy would be to bring the next items (once a video finishes), and the other items MediaCMS supports now (subtitles, speed, select quality)
  • Does it make sense to put the effort for a Plyr migration, or better update videojs?
  • How well Plyr works in mobile devices?

You mention that the current video player does not support screen rotation, are you refering to mobile devices or something else? As far as I can tell it does rotate on the mobile (at least Android).

@mgogoulos mgogoulos added the frontend Frontend issues label Oct 19, 2024
@mgogoulos mgogoulos removed their assignment Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend issues
Projects
None yet
Development

No branches or pull requests

2 participants