From 333bb240ec640e1a1ed6e2f52004a1e3feadfd17 Mon Sep 17 00:00:00 2001 From: Anup Cowkur Date: Mon, 22 Jul 2024 13:58:40 +0530 Subject: [PATCH] fix(backend): ignore cold launch greater than 30s for metrics calculation fixes #933 --- measure-backend/measure-go/measure/app.go | 1 + 1 file changed, 1 insertion(+) diff --git a/measure-backend/measure-go/measure/app.go b/measure-backend/measure-go/measure/app.go index f7e033e8d..1efa57440 100644 --- a/measure-backend/measure-go/measure/app.go +++ b/measure-backend/measure-go/measure/app.go @@ -721,6 +721,7 @@ func (a App) GetLaunchMetrics(ctx context.Context, af *filter.AppFilter, version Select("round(quantile(0.95)(cold_launch.duration), 2) as cold_launch"). Where("type = 'cold_launch'"). Where("cold_launch.duration > 0"). + Where("cold_launch.duration <= 30000"). //ignore cold launch durations greater than 30 seconds. See https://github.com/measure-sh/measure/issues/933 Where("attribute.app_version in ? and attribute.app_build in ?", af.Versions, af.VersionCodes)). With("warm_selected", sqlf.From("timings").