-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in .mdx
files with mdx.checkMdx
appear at end of file
#451
Comments
Interesting, it appears that the highlighting is in the correct location if I disable these 2 extensions 🤔 |
Funny enough, if I disable these 2 extensions, then that also disables the IntelliSense to auto-import into the file: Extensions enabled(although it is weird that the Extensions disabled...or maybe IntelliSense to auto-import is not a feature of MDX Analyzer? 🤔 There is also another IntelliSense issue below with vscode-styled-components However this appears to exhibit the opposite behavior - according to users in 413, enabling these extensions apparently caused IntelliSense suggestions to disappear on older versions (whereas I'm seeing IntelliSense suggestions only appear when the extensions are enabled): |
I’m closing this in favour of upstream issue styled-components/vscode-styled-components#448. I’m not seeing any problems while using |
This comment has been minimized.
This comment has been minimized.
Hi team! Could you describe why this has been marked as external? Thanks, |
Ok, thanks for reporting!
I think this may be only caused by certain settings in React CSS modules by @Viijay-Kr ( eg. here are my settings: "reactTsScss.autoComplete": true,
"reactTsScss.baseDir": "src",
"reactTsScss.cleanUpDefs": [
"node_modules/vite/client.d.ts",
"node_modules/next/types/global.d.ts",
"node_modules/react-scripts/lib/react-app.d.ts"
],
"reactTsScss.codelens": true,
"reactTsScss.cssAutoComplete": true,
"reactTsScss.cssDefinitions": true,
"reactTsScss.cssSyntaxColor": true,
"reactTsScss.definition": true,
"reactTsScss.diagnostics": true,
"reactTsScss.peekProperties": true,
"reactTsScss.references": true, Kapture.2024-06-28.at.15.48.48.mp4 |
I’m just not seeing it. Possibly another extension is the culprit. All TypeScript plugins interact with each other and can accidentally break other plugins. I even recall one plugin recovered issues from another at some point. Perhaps another extension is the culprit. The following command lists all VSCode extensions that register a TypeScript plugin. grep -l '"typescriptServerPlugins"' ~/.vscode/extensions/*/package.json |
Hm, I can repro with only I'll create a reproduction. |
FWIW this is how I’m testing this:
|
Here's the reproduction (also shows the missing auto-import IntelliSense - I opened #452 for that): Extensions:
Repo: https://github.com/karlhorky/repro-mdx-analyzer-missing-auto-import-intellisense Kapture.2024-06-28.at.17.33.21.mp4 |
Companion issues have been reported in these two VS Code extensions now: |
I’m re-opening this. A change was made upstream in volarjs/volar.js#216, which fixes compatibility with a number of existing TypeScript plugins. Let’s track here until that change has made its way into MDX analyzer. |
This comment has been minimized.
This comment has been minimized.
Hi! This was marked as ready to be worked on! Note that while this is ready to be worked on, nothing is said about priority: it may take a while for this to be solved. Is this something you can and want to work on? Team: please use the |
Thanks for raising the detailed issue, sadly I've had to archive https://github.com/styled-components/vscode-styled-components due to having no contributors for quite some time. It's unlikely the issue will be fixed there any time soon, I don't know if there's a replacement extension but until then it will remain the way it is. |
@remcohaszing Nice, thanks! For anyone following along, considering that volarjs/volar.js#216 was released in Once that version has been released, it can be bumped in MDX Analyzer too. |
Hi! This was closed. Team: If this was fixed, please add |
@johnsoncodehk @remcohaszing Thanks for the update to Volar 2.4 in PR #460 and the publish of The problem is half fixed: I tried out the new version with the reproduction repo from the original issue description and:
Kapture.2024-08-20.at.10.03.57.mp4 |
@karlhorky Re posting here for visibility This PR Viijay-Kr/typescript-cleanup-definitions#5 adapts similar changes done in volar project . Hopefully this fixes the issue fully |
@Viijay-Kr thanks for the publish of Kapture.2024-08-22.at.20.20.01.mp4 |
Initial checklist
Affected packages and versions
MDX VS Code Extension v1.8.9
Link to runnable example
No response
Steps to reproduce
Reproduction repo: https://github.com/karlhorky/repro-mdx-analyzer-missing-auto-import-intellisense
app-dir-mdx
example from Remco using the content below(content contains intentional TypeScript errors)
mdx-components.tsx
app/message.mdx
tsconfig.json
Expected behavior
In the screenshot above, I would expect that the 1st error would appear on line 47, covering the whole line, and the 2nd error would appear on line 49, covering the whole line
Actual behavior
In the screenshot above, the errors from the MDX VS Code extension appear on a 1-character red squiggly the end of the file in VS Code instead of on the respective lines where the errors occur
Runtime
No response
Package manager
No response
OS
macOS
Build and bundle tools
Next.js
The text was updated successfully, but these errors were encountered: