Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More elegant implementation of bad_edge #5

Open
ewu63 opened this issue Aug 30, 2018 · 3 comments
Open

More elegant implementation of bad_edge #5

ewu63 opened this issue Aug 30, 2018 · 3 comments
Labels
stale *crickets chirp*

Comments

@ewu63
Copy link
Collaborator

ewu63 commented Aug 30, 2018

I think perhaps a better implementation is to use the checkCellRatio function to automatically detect this issue, since it's not something specific to the leading edge when using joined spacing. Maybe add this as a postprocessing step before output.

@marcomangano
Copy link
Contributor

I totally support this approach, I will try and fix this soon. Also, we should ensure that the final number of sampled points is consistent with initial user input, i.e. n=n+2 before popping out the bad surf mesh elements. Right now I am doing it "manually" on my input script. This is relevant when mesh are coarsened for grid convergence, etc.

@ewu63
Copy link
Collaborator Author

ewu63 commented Aug 31, 2018

Yes very good point -- user should receive a mesh with the specified number of points. I think the main problem comes from joinedSpacing -- do you use it much? Maybe we need some sort of smoothing when joining samplings. Eventually, this should be superseded by a curvature refinement approach which should be the recommended method.

@stale
Copy link

stale bot commented Mar 20, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale *crickets chirp* label Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale *crickets chirp*
Projects
None yet
Development

No branches or pull requests

2 participants