Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactoring calculation of total VHF from partial data #55

Open
rmatsum836 opened this issue Jul 27, 2021 · 0 comments
Open

Consider refactoring calculation of total VHF from partial data #55

rmatsum836 opened this issue Jul 27, 2021 · 0 comments

Comments

@rmatsum836
Copy link
Collaborator

rmatsum836 commented Jul 27, 2021

Per a conversation with @lisankim0321, the dictionary used to compute the total VHF from the partial data is a little clunky. Currently the key of the dictionary is a tuple of MDTraj.Atom objects, which was decided upon as these objects carry both atom name and element name information.

Perhaps it may be easier to have the user pass in two separate dictionaries. The first with atom name as key and g_r_t data as value. The second with atom name as key and element name as value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant