Keep spaces in image path #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file name of an image has spaces, the parse function will replace the spaces with '%20'. This way the reference won't be recognized by firebase. So after the parse functions I changed it back to regular spaces.
|
Thanks, I'll take a look at this soon. |
mattreid1
requested changes
May 1, 2021
| @@ -61,7 +61,7 @@ class FirebaseImage extends ImageProvider<FirebaseImage> { | |||
|
|
|||
| static String _getImagePath(String location) { | |||
| final uri = Uri.parse(location); | |||
| return uri.path; | |||
| return uri.path.replaceAll('%20', ' '); | |||
There was a problem hiding this comment.
In testing, I've found an issue where if the image has "%20" in the filename, it will replace that with a space as well. Any ideas?
There was a problem hiding this comment.
Just an idea. It maybe not the best, but replace "%20" with something completely unique value like "|-|" or anything (which you think shouldn't be in filename or pathname) prior to parse which converts spaces to "%20". And then lastly replace back all the occurence of your uniquely added string with "%20".
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file name of an image has spaces, the parse function will replace the spaces with '%20'. This way the reference won't be recognized by firebase. So after the parse functions I changed it back to regular spaces.