Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why is alexa-app embeded in vendor/ rather than installing as an npm module? #3

Closed
mreinstein opened this issue Jun 17, 2016 · 1 comment

Comments

@mreinstein
Copy link

mreinstein commented Jun 17, 2016

https://github.com/mattotodd/node-red-contrib-alexa/blob/master/vendor/alexa-app.js looks identical to the alexa-app module from npm.

Were there slight changes made to the local copy of this module? Could we instead just pull that module in as a normal dependency? would reduce a lot of duplication and leverage node/npm's module system more elegantly.

@mattotodd
Copy link
Owner

Yes, i had to make a slight change to the alex-app to support node-red, and I have a pull request open on that repo with the changes. https://github.com/matt-kruse/alexa-app/pull/70

If/when that gets pulled in, it will become a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants