Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab hook's thread relations don't play well with Matrix clients that don't support threads #959

Open
zecakeh opened this issue Jun 29, 2024 · 0 comments

Comments

@zecakeh
Copy link
Contributor

zecakeh commented Jun 29, 2024

Currently, the GitLab hook keeps track of "discussions" for comments, and sends the event for the new comment in a thread as ${author} replied with ${n} comment.

In a Matrix client that doesn't support threads, it becomes unclear what was replied to. There is no rich reply fallback relation in the thread relation so they can't link it to the previous message in the thread, and there is no context in the message, even regarding which MR/issue it belongs to, so the notice doesn't feel very useful.

The simple solution here would be to send the rich reply fallback relation, which means we need to always keep track of the latest event ID, as well as the thread root ID for every discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant