Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how server logs are dumped #708

Open
kegsay opened this issue Feb 14, 2024 · 0 comments
Open

Change how server logs are dumped #708

kegsay opened this issue Feb 14, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@kegsay
Copy link
Member

kegsay commented Feb 14, 2024

Currently it dumps server logs to stdout and only on failure. This can always be spat out if COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1. However, this isn't the most discoverable, as both Erik and vdh asked me how to get server logs from Complement in the same day.

It would be better if:

  • we always printed server logs,
  • to disk,
  • based on the hs name,
  • and then removed COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS.

For extra discoverability, indicating that server logs are going to file X would be useful.

This would be a breaking change to the Complement API.

@kegsay kegsay added the enhancement New feature or request label Feb 14, 2024
@kegsay kegsay added this to the v1 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant