From 71f704bd4e42a6b3c933bc346aac521b4edfe7d4 Mon Sep 17 00:00:00 2001 From: Kegan Dougal <7190048+kegsay@users.noreply.github.com> Date: Wed, 15 May 2024 11:26:40 +0100 Subject: [PATCH] Unskip tests now that the bugs are fixed --- tests/notification_test.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/notification_test.go b/tests/notification_test.go index f012e38..3d69a02 100644 --- a/tests/notification_test.go +++ b/tests/notification_test.go @@ -267,7 +267,6 @@ func TestMultiprocessNSEBackupKeyMacError(t *testing.T) { t.Skipf("rust only") return } - t.Skipf("pending bugfix") tc, roomID := createAndJoinRoom(t) // Alice starts syncing to get an encrypted room set up alice := tc.MustLoginClient(t, tc.Alice, tc.AliceClientType, WithPersistentStorage(), WithCrossProcessLock("main")) @@ -441,23 +440,19 @@ func TestMultiprocessDupeOTKUpload(t *testing.T) { t.Skipf("rust only") return } - t.Skipf("WIP") tc, roomID := createAndJoinRoom(t) // start the "main" app alice := tc.MustLoginClient(t, tc.Alice, tc.AliceClientType, WithPersistentStorage(), WithCrossProcessLock("main")) aliceAccessToken := alice.Opts().AccessToken - // let OTKs be uploaded - time.Sleep(time.Second) - // prep nse process nseAlice := tc.MustCreateMultiprocessClient(t, tc.AliceClientType.Lang, tc.ClientCreationOpts(t, tc.Alice, tc.AliceClientType.HS, WithPersistentStorage(), WithAccessToken(aliceAccessToken), WithCrossProcessLock(api.ProcessNameNSE), )) aliceUploadedNewKeys := false - // artificially slow down the HTTP responses, such that we will have 2 in-flight /keys/upload requests + // artificially slow down the HTTP responses, such that we will potentially have 2 in-flight /keys/upload requests // at once. If the NSE and main apps are talking to each other, they should be using the same key ID + key. // If not... well, that's a bug because then the client will forget one of these keys. tc.Deployment.WithSniffedEndpoint(t, "/keys/upload", func(cd deploy.CallbackData) {