Review people found does not work on Nextcloud Hub 9 (30.0.0)

[xegby]

Face Recognition app uses the core/templates/message.html to show the clusters found. The template was removed from the Nextcloud server some time ago.
So the webserver answers 404 (Not Found) to the app:

Returning back the template from older Nexctloud version to my installation helped to solve the problem.

But I guess we need more centralized solution in the app.

[vwbusguy]

Seeing the same thing here on NC30 as well. I assume some of this may be fixed with #778 ?

[vwbusguy]

The issue here seems to be that the "message.html" template no longer exists in core/templates in Nextcloud as of NC30.

It was removed with this commit: nextcloud/server@8d5c013

The OC.dialogs was replaced with a new @nextcloud/dialogs, so facerecognition just needs updated to call the new method.

[vwbusguy]

The good news is that this is only in two places. If @matiasdelellis doesn't beat me to it, I might test out swapping those two calls and submit a PR for it a bit later on.

[vwbusguy]

OC.dialogs.confirm() hasn't been removed upstream. Rather, it looks like it just needs the updated templating refs for Nextcloud 30. I'm going to wait until #778 gets merged or @matiasdelellis takes a look before I spend any more time on this.

The dev docs note that the OC javascript object can have breaking changes from one release to the next, so I think we've simply found one of those.

[matiasdelellis]

Thanks for the report, it will be fixed in the next release this week. 😄

[vwbusguy]

This is fixed for me in the new release.