Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is double grid needed? #78

Open
imyujie opened this issue Sep 17, 2018 · 1 comment
Open

Why is double grid needed? #78

imyujie opened this issue Sep 17, 2018 · 1 comment

Comments

@imyujie
Copy link

imyujie commented Sep 17, 2018

Just came across this interesting project and tried https://matejlatin.github.io/Gutenberg/.

I was wondering why we need double grid here. And I saw there's a lot of margins set to be 1.5 leadings or 0.5 leading. Why not just use integer number of leadings to ensure all the elements are aligned with the 1 leading grid?

A quick idea: is it possible to set dynamic margins? Let's say if an element's line height is set to 1.5 leadings with 1 leading bottom margin, and it gets 3 lines at total. For this case, we can make bottom margin as 1.5 leadings then the total height of this module (including element height and bottom margin) can be 6 leadings which won't break the 1 leading grid rules.

@matejlatin
Copy link
Owner

@imyujie it's just something that helps with flexibility when it comes to layout. Headings for example usually need a smaller line-height and using the .5 grid allows that, and they don't break the grid. You could disable the double grid and stick to whole leading units only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants