Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with odd python version leading to this error #523

Open
WillPPK opened this issue Jun 18, 2023 · 7 comments
Open

Issue with odd python version leading to this error #523

WillPPK opened this issue Jun 18, 2023 · 7 comments

Comments

@WillPPK
Copy link

WillPPK commented Jun 18, 2023

The command

martinize2 -f combine.pdb -x cg-prot.pdb -o topol.top -p backbone -pf 1000 -elastic -el 0.6 -eu 0.8

were run on two independent workstations. However, one with the more recent Anaconda installation show this error.

Traceback (most recent call last):
  File "/Users/baetannie/anaconda3/bin/martinize2", line 824, in <module>
    entry()
  File "/Users/baetannie/anaconda3/bin/martinize2", line 757, in entry
    rubber_band_processor.run_system(system)
  File "/Users/baetannie/anaconda3/lib/python3.10/site-packages/vermouth/processors/processor.py", line 37, in run_system
    mols.append(self.run_molecule(molecule))
  File "/Users/baetannie/anaconda3/lib/python3.10/site-packages/vermouth/processors/apply_rubber_band.py", line 520, in run_molecule
    apply_rubber_band(molecule, self.selector,
  File "/Users/baetannie/anaconda3/lib/python3.10/site-packages/vermouth/processors/apply_rubber_band.py", line 316, in apply_rubber_band
    molecule.moltype,
  File "/Users/baetannie/anaconda3/lib/python3.10/site-packages/vermouth/molecule.py", line 662, in __getattr__
    raise AttributeError('Unknown attribute "{}".'.format(name))
AttributeError: Unknown attribute "moltype".

The workstation with python3.8.5 works fine, whilst the laptop with python3.10 leads to this error.

Maybe a python version and dependency annotations are needed for clarities.

@pckroon
Copy link
Member

pckroon commented Jun 19, 2023

Hello hello!
Thanks for reporting this, it's definitely not supposed to be happening --- to the best of my knowledge there is no code in the project that's dependent on Python version.
Could you check (and report) the versions of VerMoUTH and its dependencies? In particular I think the version of networkx is important.

@WillPPK
Copy link
Author

WillPPK commented Jun 24, 2023

The VerMouTH is 0.9.2
networkx is 2.8.4
numpy is 1.23.5

Thanks!

@pckroon
Copy link
Member

pckroon commented Jun 26, 2023

And these are the same for both? Our tests run for every python version between 3.7 and 3.11... https://github.com/marrink-lab/vermouth-martinize/blob/master/.github/workflows/run_tests.yml#L24

@fgrunewald
Copy link
Member

@WillPPK is this issue still active?

@WillPPK
Copy link
Author

WillPPK commented Jun 27, 2023 via email

@WillPPK
Copy link
Author

WillPPK commented Jun 27, 2023

These didn't work on the workstation containing:
The VerMouTH is 0.9.2
networkx is 2.8.4
numpy is 1.23.5

But working fine on the workstation with:
VerMouTH 0.7.3
networkx is 2.6.3
numpy is 1.22.3

Maybe it's the more recent networkx?

@fgrunewald
Copy link
Member

fgrunewald commented Jun 28, 2023

@WillPPK thanks for reporting the versions. I think the error is not related to the networkx version but the changes in vermouth going from 0.7.3 to 0.9.2. Can you share the combine.pdb with us? My working hypothesis is that in the newer version the moltypes are not correctly shared between protein copies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants