New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make avatar icon size same across the login methods #538

Open

hanbyul-here opened this issue Oct 23, 2017 · 0 comments

Member

hanbyul-here commented Oct 23, 2017

Currently, we set up the icon size for 18px when user logged in with Github, 24px when user logged in with email. That was because (if I remember correctly) we were using default avatar which has a lot of negative space in it, making itself look smaller. Now that we can fetch the avatar image with e-mail address, (but we still don't know it would work or not, so we have to send the fallback image too) it maybe time to make those icons size same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment