Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap marker to pixel if it's lngLat is unchanged #13352

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

C2thehris
Copy link

@C2thehris C2thehris commented Dec 14, 2024

Signed-off-by: C2thehris [email protected]

Closes #13351

Verified markers no longer move after change:
https://github.com/user-attachments/assets/c8cd94a1-6db0-4b09-862b-21ac6120b0fa

Launch Checklist

  • Make sure the PR title is descriptive and preferably reflects the change from the user's perspective.
  • Add additional detail and context in the PR description (with screenshots/videos if there are visual changes).
  • Manually test the debug page.
  • Write tests for all new functionality and make sure the CI checks pass.
  • Document any changes to public APIs.
  • Post benchmark scores if the change could affect performance.
  • Tag @mapbox/map-design-team @mapbox/static-apis if this PR includes style spec API or visual changes.
  • Tag @mapbox/gl-native if this PR includes shader changes or needs a native port.

@C2thehris C2thehris marked this pull request as ready for review December 14, 2024 17:39
@C2thehris C2thehris requested a review from a team as a code owner December 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markers shift slightly when the map is double clicked
1 participant