Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: (6) Could not resolve host: null #3

Open
silasjoisten opened this issue Feb 23, 2021 · 0 comments
Open

curl: (6) Could not resolve host: null #3

silasjoisten opened this issue Feb 23, 2021 · 0 comments

Comments

@silasjoisten
Copy link

Hello,
thank you for this github action. I think i found a bug. Maybe you can help out with this.
When i have an invalid Kubernetes config. the check is failing with following error:

executed: /kubeval --directories deployments --output stdout --strict=true --kubernetes-version=1.19 --openshift=false --ignore-missing-schemas=true
return code: 1
curl: (6) Could not resolve host: null

i spent some time on this and figured out, that the curl against the github api is failing because no environment variable COMMENTS_URL isset. I added the the environment variable with https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/issues/${PR_NUMBER}/comments like its described in the github api docs.

am i missing something?

my configuration looks now like the following:

name: Kubernetes Validation
on: [push]
jobs:
  validation:
    runs-on: ubuntu-latest
    env:
      COMMENTS_URL: https://api.github.com/repos/${REPO_OWNER}/${REPO_NAME}/issues/${PR_NUMBER}/comments
    steps:
      - uses: actions/checkout@v2
      - uses: makocchi-git/[email protected]
        with:
          files: deployments
          comment: true
          token: ${{ secrets.GITHUB_TOKEN }}
          version: 1.19
          strict: true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant