Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default global version #2

Open
3 tasks
dlercier opened this issue Dec 10, 2024 · 2 comments
Open
3 tasks

Create a default global version #2

dlercier opened this issue Dec 10, 2024 · 2 comments
Labels
data Relative to data

Comments

@dlercier
Copy link
Contributor

dlercier commented Dec 10, 2024

Provide a global version of the datasets used :

  • Geolocalization : Replace the BAN API by Nominatim
  • Weather : Use a global dataset as https://gpm.nasa.gov/data/imerg
  • Water prices : Make this information optional

This issue is linked to #1

@dlercier dlercier added the data Relative to data label Dec 10, 2024
@CBalsier
Copy link

for the map, I saw that the map component uses IGN dataplatform to get OSM tiles, are they available outside France as well?

@CBalsier
Copy link

also regarding the geolocalization (in fact, geocoding, address -> coordinates), currently done here:

const response = await fetch(`https://api-adresse.data.gouv.fr/search/?q=${addressToSearch}&limit=${LIMIT}`);

If I remember well, the BAN API also returns a "quality" parameter (between 0 and 1 or 0 and 100, 1/100 being the better, perfect match) that is used to rank the results. I think that it could be useful to ask both BAN and Nominatim for the coordinates matching the address, and then check this quality parameter to take "the better result". Their parameters are likely not matching because the way to compute them is different, but we could setup a threshold, for example:

  • if the BAN result has 0.30 in quality, and the Nominatim is far above -> take the Nominatim
  • if the BAN doesn't return anything -> take Nominatim
  • if Nominatim doesn't return anything but BAN does -> take BAN

(could also be improved by using other "BAN" from other countries, like PDOK for the Netherlands: https://www.pdok.nl/introductie/-/article/pdok-locatieserver-1 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Relative to data
Projects
None yet
Development

No branches or pull requests

2 participants