Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fysetc theme #1957

Closed
wants to merge 1 commit into from

Conversation

zzcatvs
Copy link

@zzcatvs zzcatvs commented Jul 22, 2024

Description

This PR adds a Fysetc theme.

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

fysetc-1
fysetc-2

[optional] Are there any post-deployment tasks we need to perform?

none

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 22, 2024
@zzcatvs zzcatvs changed the title feat(theme):add fysetc theme. feat(theme):add fysetc theme Jul 22, 2024
@zzcatvs zzcatvs changed the title feat(theme):add fysetc theme - feat(theme):add fysetc theme Jul 22, 2024
@zzcatvs zzcatvs changed the title - feat(theme):add fysetc theme feat: add fysetc theme Jul 22, 2024
@meteyou
Copy link
Member

meteyou commented Jul 22, 2024

Thank you very much for your PR! We appreciate your contribution, but we want to clarify that built-in themes are limited to our vendor sponsors or open-source projects (such as Voron and VZBot). Fysetc is not currently a vendor sponsor of Mainsail, nor is it an open-source community. Built-in themes should give our sponsors a little bonus and recognize their support.

However, you are welcome to add your theme to the community themes. This works via our docs repo. Create a repo with the theme data and enter the theme here via a PR: https://github.com/mainsail-crew/gb-docs/blob/main/_data/themes.csv. This will add this theme to our docs page: https://docs.mainsail.xyz/overview/features/themes/themes

We hope for your understanding and look forward to more contributions from you.

@meteyou
Copy link
Member

meteyou commented Nov 14, 2024

I close this PR, because of no respond (also per PN)...

@meteyou meteyou closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants