Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Customer account confirm - StateException should not be logged as critical error #39487

Open
5 tasks done
m2-assistant bot opened this issue Dec 17, 2024 · 3 comments · May be fixed by #39466
Open
5 tasks done

[Issue] Customer account confirm - StateException should not be logged as critical error #39487

m2-assistant bot opened this issue Dec 17, 2024 · 3 comments · May be fixed by #39466
Assignees
@engcom-Bravo
Labels
Issue: needs update Additional information is require, waiting for response Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 17, 2024

This issue is automatically created based on existing pull request: #39466: Customer account confirm - StateException should not be logged as critical error

Description (*)

The error "The account is already active," etc., should not be logged as a critical exception since it is more of a user error rather than a programming issue that needs to be addressed.
Instead of using "addException" which logs the StateExpection I changed to to a normal error message.

Manual testing scenarios (*)

  • Create a customer account
  • Confirm
  • Confrm again

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Dec 17, 2024 that will close this issue
Open
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Dec 17, 2024
@engcom-Bravo engcom-Bravo self-assigned this Dec 17, 2024
@m2-assistant M2 Assistant
Copy link
Author

m2-assistant bot commented Dec 17, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Dec 17, 2024
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 17, 2024
@engcom-Bravo
Copy link
Contributor

Hi @mvenghaus,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop magento instance and we are not able to reproduce the issue.Kindly refer the attached video.

Screen.Recording.2024-12-19.at.10.45.26.am.mov

We are not getting any error.Could you please let us know if we are missing anything and also please provide us screenshots or screencast.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 19, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 19, 2024
@mvenghaus
Copy link

Hey,

thanks for taking care.

This is not visible to the user. It's messing up the exception log for developers. An exception should only be logged if it's critical and not based on the user's behavior.

Regards
Marcus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Bravo engcom-Bravo

Labels
Issue: needs update Additional information is require, waiting for response Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Issue Confirmation and Triage Board
Status: Needs Update
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Customer account confirm - StateException should not be logged as critical error mvenghaus/magento2
2 participants
@mvenghaus @engcom-Bravo