Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFTF: Submitting Email To Friend Form with enabled captcha #32830

Open
wants to merge 6 commits into
base: 2.4-develop
Choose a base branch
from
Open

MFTF: Submitting Email To Friend Form with enabled captcha #32830

wants to merge 6 commits into from

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Apr 23, 2021 •
edited by m2-assistant bot
Loading

This PR contains MFTF test for submitting email to friend form with enabled captcha

Steps to reproduce:

1 - Enable captcha on email to friend form
2 - Create product
3 - Create customer
4 - Login as customer
5 - Navigate to created product
6 - Navigate to email to friend form
7 - Submit the form with wrong captcha values
8 - Submit the form with correct captcha values
9 - Perform assertions

Resolved issues:

  1. resolves [Issue] MFTF: Submitting Email To Friend Form with enabled captcha #39462: MFTF: Submitting Email To Friend Form with enabled captcha

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2021

Hi @DmitryTsymbal. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Captcha Component: Catalog Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 23, 2021
@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@dmytro-ch dmytro-ch self-assigned this Apr 26, 2021
@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Unit Tests

@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

No builds to run for your request.

@dmytro-ch dmytro-ch added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 26, 2021
@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

No builds to run for your request.

@dmytro-ch
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

No builds to run for your request.

@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch
Copy link
Contributor

@magento run Unit Tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 27, 2021
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-9049 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Hi @DmitryTsymbal, Thanks for your contribution.Please resolve the conflicts to move on this PR

@DmitryTsymbal
Copy link
Contributor Author

@magento run all tests

@engcom-Dash engcom-Dash self-assigned this Dec 5, 2024
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Semantic Version Checker, Functional Tests EE, Functional Tests CE, Functional Tests B2B, Database Compare

@engcom-Dash
Copy link
Contributor

@magento run Semantic Version Checker, Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests EE

@engcom-Dash
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Dec 10, 2024
Open
@engcom-Dash
Copy link
Contributor

Hello @DmitryTsymbal,

Thanks for the contributions!

This PR is related to MFTF, so QA is not applicable.

Since we have a green build, I'm moving it to "Merge in Progress."
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@dmytro-ch dmytro-ch

@engcom-Dash engcom-Dash

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Captcha Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: ready for testing Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Status: Merge in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Submitting Email To Friend Form with enabled captcha
5 participants
@DmitryTsymbal @dmytro-ch @magento-engcom-team @engcom-Delta @engcom-Dash