Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(tests): MadaraBackend::open_for_testing fn unavailable to tests #293

Open
1 task done
Tracked by #413
, #419
...
notlesh opened this issue Oct 1, 2024 · 1 comment · May be fixed by #445
Open
1 task done
Tracked by #413
, #419
...

bug(tests): MadaraBackend::open_for_testing fn unavailable to tests #293

notlesh opened this issue Oct 1, 2024 · 1 comment · May be fixed by #445
Labels
bug Something isn't working

Comments

@notlesh
Copy link
Contributor

notlesh commented Oct 1, 2024 •
edited
Loading

Is there an existing issue?

  • I have searched the existing issues

Description of bug

Running certain tests results in compilation errors similar to:

   Compiling mc-block-import v0.7.0 (/home/stephen/dev/msl/starkware/madara/crates/client/block_import)
error[E0599]: no function or associated item named `open_for_testing` found for struct `mc_db::MadaraBackend` in the current scope
   --> crates/client/block_import/src/verify_apply.rs:343:24
    |
343 |         MadaraBackend::open_for_testing(chain_config.clone())
    |                        ^^^^^^^^^^^^^^^^ function or associated item not found in `MadaraBackend

This is related to the testing feature flag not being passed to the crate. One workaround is to add a testing feature to the given crate such as:

testing = ["mc-db/testing"]

And then run tests with this feature, e.g.:

cargo test -p mc-block-import --features=testing

Steps to reproduce

Run cargo test -p mc-block-import from the project root directory.

Or attempt to run any tests in verify_apply.rs in VSCode.
@notlesh notlesh mentioned this issue Oct 1, 2024
Closed
@notlesh
Copy link
Contributor Author

notlesh commented Oct 1, 2024 •
edited
Loading

#295 seems to fix this, but I have another concern: why don't the mc-block-import tests run with cargo test --all?

@notlesh notlesh mentioned this issue Oct 1, 2024
Merged
@antiyro antiyro added this to Madara Oct 8, 2024
@Trantorian1 Trantorian1 added the bug Something isn't working label Dec 10, 2024
@Trantorian1 Trantorian1 mentioned this issue Dec 10, 2024
Open
11 tasks
This was referenced Dec 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Madara
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compilation): crate-level compilation madara-alliance/madara
2 participants
@notlesh @Trantorian1