Replace command of fetching replica status for MySQL 8.4 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11226401964Details
💛 - Coveralls |
This reverts commit 2523d0b.
Arthur1
force-pushed
the
slave-to-replica
branch
from
b1671ed to
19150f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOW SLAVE STATUScommand was deprecated in MySQL 8.0, but has been removed in 8.4. In other words, mackerel-plugin-mysql calling this command cannot work with MySQL 8.4.This pull request makes the plugin to call
SHOW REPLICA STATUScommand instead ofSHOW SLAVE STATUSif MySQL version is 8.0.22 or later.I also fixed a test script that fails because MySQL container for testing had moved up to 8.4.