Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options object #159

Open
3 tasks
dougmoscrop opened this issue Dec 10, 2015 · 1 comment
Open
3 tasks

Options object #159

dougmoscrop opened this issue Dec 10, 2015 · 1 comment

Comments

@dougmoscrop
Copy link
Collaborator

Let's refactor .create to take an options object.

I propose that since the current version takes URL as the first parameter, it's probably always true that arguments.length >= 1 and that arguments[0] is a string, therefore if arguments.length === 1 and arguments[0] is an object, they're using the proposed new style. I believe this should be backwards compatible.

Schedule:

  • Introduce the new option (5.3)
  • Deprecate the old style (5.4)
  • Remove the old style (6.0)

Thoughts?

@venil7
Copy link
Contributor

venil7 commented Dec 10, 2015

Sounds good!
I would however introduce new option in next minor, then - deprecate in next next minor, then - remove in next major to stay semver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants