Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The first link you connect to Switch (Any) isn't of the right type #851

Open
LukeG89 opened this issue Dec 11, 2024 · 8 comments
Open
Labels
bug Something isn't working

Comments

@LukeG89
Copy link

LukeG89 commented Dec 11, 2024

There is a problem with Switch (Any). As said in the title, the first link you connect isn't of the right type. Plus, it keeps the "dot" inside the first input like it's optional, but not the other ones (especially the last one)

In this video I'm using the current ComfyUI frontend (1.4.13)

Switch-Test.mp4

I think this problem also leads to corrupted linking data (reported by rgthree feature), it happened a couple of times with a workflow. Maybe it's related to this issue, but to be honest I have not investigated, I just stopped using the switch.
Nevermind about that, I tried to reproduce the issue, but everything seems to work fine (maybe it has been fixed with another commit or something, I don't know)

Debug logs:

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
[START] Security scan
[DONE] Security scan
## ComfyUI-Manager: installing dependencies done.
** ComfyUI startup time: 2024-12-11 17:15:58.711234
** Platform: Windows
** Python version: 3.11.9 (tags/v3.11.9:de54cf5, Apr  2 2024, 10:12:12) [MSC v.1938 64 bit (AMD64)]
** Python executable: E:\python_embeded\python.exe
** ComfyUI Path: E:\ComfyUI
** Log path: E:\comfyui.log

Prestartup times for custom nodes:
   2.0 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Manager

Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.6.0.dev20241204+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI\web
### Loading: ComfyUI-Impact-Pack (V8.0.1)
[Impact Pack] Wildcards loading done.
### Loading: ComfyUI-Manager (V2.55.4)
### ComfyUI Version: v0.3.7-14-g7a7efe84 | Released on '2024-12-11'

Import times for custom nodes:
   0.0 seconds: E:\ComfyUI\custom_nodes\websocket_image_save.py
   0.0 seconds: E:\ComfyUI\custom_nodes\loadImageWithSubfolders.py
   0.1 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Impact-Pack
   0.3 seconds: E:\ComfyUI\custom_nodes\ComfyUI-Manager

Starting server

To see the GUI go to: http://127.0.0.1:8188
@LukeG89
Copy link
Author

LukeG89 commented Dec 14, 2024

The same "first link" issue is present in Inversed Switch (Any)

image

@ltdrdata ltdrdata added the bug Something isn't working label Dec 15, 2024
ltdrdata added a commit that referenced this issue Dec 19, 2024
…ge output, remove the input connection instead of the output.

#851 (comment)
@ltdrdata
Copy link
Owner

The same "first link" issue is present in Inversed Switch (Any)

image

This is fixed.

@LukeG89
Copy link
Author

LukeG89 commented Dec 19, 2024

@ltdrdata I still have the issue
ComfyUI-Impact-Pack (V8.1.2)

Same-issue.mp4

@ltdrdata
Copy link
Owner

ltdrdata commented Dec 19, 2024

@ltdrdata I still have the issue ComfyUI-Impact-Pack (V8.1.2)

Same-issue.mp4

There is a problem with Switch (Any). As said in the title, the first link you connect isn't of the right type. Plus, it keeps the "dot" inside the first input like it's optional, but not the other ones (especially the last one)

In this video I'm using the current ComfyUI frontend (1.4.13)

Switch-Test.mp4
I think this problem also leads to corrupted linking data (reported by rgthree feature), it happened a couple of times with a workflow. Maybe it's related to this issue, but to be honest I have not investigated, I just stopped using the switch. Nevermind about that, I tried to reproduce the issue, but everything seems to work fine (maybe it has been fixed with another commit or something, I don't know)

Ah, I was mistaken about the issue. The issue I fixed was related to select_on_prompt and has nothing to do with this one.

However, I don't understand the issue you're pointing out. The moment you make the first connection with an image, the switch's input and output are bound to IMAGE type (sky blue dot) correctly.

@LukeG89
Copy link
Author

LukeG89 commented Dec 19, 2024

However, I don't understand the issue you're pointing out. The moment you make the first connection with an image, the switch's input and output are bound to IMAGE type (sky blue dot) correctly.

Yes, but the first link is not of the correct type. Not a big issue though

@ltdrdata
Copy link
Owner

However, I don't understand the issue you're pointing out. The moment you make the first connection with an image, the switch's input and output are bound to IMAGE type (sky blue dot) correctly.

Yes, but the first link is not of the correct type. Not a big issue though

Oh do you referring connection color?

@LukeG89
Copy link
Author

LukeG89 commented Dec 19, 2024

Yep

@LukeG89
Copy link
Author

LukeG89 commented Dec 19, 2024

Maybe the "Bug" tag for that was too much 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants