Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM specfile cleanup #265

Closed
davidcoutadeur opened this issue Jan 26, 2024 · 2 comments · Fixed by #246
Closed

RPM specfile cleanup #265

davidcoutadeur opened this issue Jan 26, 2024 · 2 comments · Fixed by #246
Milestone

Comments

@davidcoutadeur
Copy link
Contributor

This issue is just for documenting the job already done by @xavierba in MR #246

The goal is to clean the specfile with:

  • typos
  • good practices
  • obsolete techniques
@davidcoutadeur
Copy link
Contributor Author

For the record, the cleaning that have been done in the issue is also pushed at debian packaging here: #264

@coudot coudot added this to the 2.2 milestone Jan 26, 2024
@davidcoutadeur
Copy link
Contributor Author

I list here the evolutions that change the previous behaviour:

  • name more precisely the licence: BSD -> BSD-3-Clause
  • version is temporarily named 2.2. When the package would be released, we have to define the correct final version (2.2.0?)
  • new variable in specfile: %%global snapshot 1 now permits to build snapshot release for tests
  • when building manually, we must now use the target package *-dist.tar.gz and no more the .zip
  • Nagios script is now bundle as a different package: nagios-plugins-lsc
  • Nagios scripts are now deployed in the more standard destination: /usr/lib/nagios/plugins/
  • Nagios package is requiring nagios-common, which is available in EPEL repository
  • LSC package is now requiring crontabs
  • home directory of lsc user is no more /etc/lsc, but /var/lib/lsc, and this directory is owned by lsc user
  • lsc user don't have a default shell any more, but /sbin/nologin
  • don't delete lsc user to prevent possible uid re-use
  • don't deploy any more /usr/share/doc/lsc/lib64 and /usr/share/doc/lsc/bin/lsc symlinks (previously used to run the samples from the lsc doc directory). The new lsc package is also removing these symlinks.
  • now deploying an html documentation generated from the README.md (outdated though)
  • now deploying some manpages (outdated though)
  • don't systematically change /var/log/lsc owner in %post to lsc. lsc is still declared the owner of /var/log/lsc, but as a directory attribute (%attr)
  • hsqldb script is now using /var/lib/lsc as its working directory, and no more /var/lsc
  • hsqldb script is now using /run/hsqldb.pid and no more /var/hsqldb.pid
  • useless windows .bat files are now removed from the package
  • specfile is renamed from lsc-core.spec to lsc.spec

davidcoutadeur pushed a commit that referenced this issue Jan 26, 2024
RPM specfile cleanup (#265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants