Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod should be updated to v4 #50

Open
WKBae opened this issue Oct 26, 2023 · 0 comments
Open

go.mod should be updated to v4 #50

WKBae opened this issue Oct 26, 2023 · 0 comments

Comments

@WKBae
Copy link

WKBae commented Oct 26, 2023

Describe the bug
As the major version tag is bumped to v4, module path in go.mod should be updated to v4.

module github.com/lokalise/go-lokalise-api/v3

When trying to upgrade with go get:

$ go get github.com/lokalise/[email protected]
go: github.com/lokalise/[email protected]: invalid version: go.mod has post-v4 module path "github.com/lokalise/go-lokalise-api/v3" at revision v4.0.0

When manually set require as github.com/lokalise/go-lokalise-api/v3 v4.0.0 in my(importing) go.mod:

$ go get
go: errors parsing go.mod:
/.../my-project/go.mod:14:2: require github.com/lokalise/go-lokalise-api/v3: version "v4.0.0" invalid: should be v3, not v4

When set github.com/lokalise/go-lokalise-api/v4 v4.0.0:

$ go get              
go: github.com/lokalise/go-lokalise-api/[email protected]: go.mod has non-.../v4 module path "github.com/lokalise/go-lokalise-api/v3" (and .../v4/go.mod does not exist) at revision v4.0.0

Setting up from new, empty project:

$ go get github.com/lokalise/go-lokalise-api
go: github.com/lokalise/go-lokalise-api: no matching versions for query "upgrade"

To Reproduce
Try upgrading to v4 in existing project, or install newly:

mkdir temp && cd temp
go mod init temp
go get github.com/lokalise/go-lokalise-api

Expected behavior
It should upgrade to v4 well.

Your environment:
darwin/arm64 go1.19.5 and go1.21.3

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant