Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another RTD config fix #238

Merged
merged 1 commit into from
Jun 5, 2024
Merged

another RTD config fix #238

merged 1 commit into from
Jun 5, 2024

Conversation

newville
Copy link
Member

@newville newville commented Jun 5, 2024

OK, this time for sure! See the discussion at #236 too.

One can enable RTD rendering on PRs: https://docs.readthedocs.io/en/stable/guides/pull-requests.html. That needs Admin access to the RTD config, which only @lebigot has (maybe we can fix this?).

In the meantime, I enabled RTD rendering on my own fork of uncertainties, and there I can set "build on PRs".
With this PR, the docs do build, with results at https://test-uncertainties.readthedocs.io/en/latest/

I'll suggest that as a better approach to avoiding the sort of flailing around I was doing over the past couple of days:

 when working on doc changes, enable test rendering of the RTD docs from a PR from 
 a personal fork and demonstrate that the build is successful as part of the  PR.

@newville newville requested a review from andrewgsavage June 5, 2024 02:23
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.29%. Comparing base (5e54598) to head (ecdf337).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   48.29%   48.29%           
=======================================
  Files          12       12           
  Lines        1903     1903           
=======================================
  Hits          919      919           
  Misses        984      984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewgsavage andrewgsavage merged commit 166a56b into lmfit:master Jun 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants