Use etcetera instead of directories #1108
Conversation
| // Windows: ~\AppData\Roaming\Vim\Vim Clap\config\config.toml | ||
| let config_file_path = Dirs::project().config_dir().join("config.toml"); | ||
| let config_file_path = Dirs::config_dir().join("config.toml"); |
There was a problem hiding this comment.
Can we keep the support of ~/Library/Application\ Support/org.vim.Vim-Clap/config.toml on macOS? This will ensure compatibility for existing macOS users, preventing any complaints about their current configuration file no longer working.
There was a problem hiding this comment.
I can add the logic to look on both places.
|
This will have to wait until lunacookies/etcetera#22 lands and is released if you want to stay compatible. |
lu-zero
force-pushed
the
use-etcetera
branch
from
c8fe9a7 to
f782a81
Compare
It provides more flexibility and it has a better default for cli tools. Fixes liuchengxu#1107.
lu-zero
force-pushed
the
use-etcetera
branch
from
f782a81 to
f2b600a
Compare
|
The upstream PR has been pending for quite a while, I don't mind using a patched dep of etcetera since it seems to be stable if you would like this PR merged into vim-clap sooner. CI failure is unrelated and can be ignored. |
|
I wished to not bring in another custom version of the same logic, if only the |
It provides more flexibility and it has a better default for cli tools.
Fixes #1107.