Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the OFF command in the climate on code 1344 #154

Open
Itay1787 opened this issue Nov 8, 2024 · 2 comments
Open

Change the OFF command in the climate on code 1344 #154

Itay1787 opened this issue Nov 8, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Itay1787
Copy link

Itay1787 commented Nov 8, 2024

Hi, need to change the shutdown command in code number 1344
Because the existing command contains an "X-FAN" function, it actually leaves the AC on ten minutes after the OFF command was given.
And this is not the desired thing by default.
So it needs to be changed

{
  "manufacturer": "Tadiran",
  "supportedModels": ["Remote Control YB1FA", "Tadiran Inverter"],
  "commandsEncoding": "Base64",
  "supportedController": "Broadlink",
  "temperatureUnit": "C",
  "minTemperature": 16,
  "maxTemperature": 30,
  "precision": 1,
  "operationModes": ["auto", "cool", "dry", "fan_only", "heat"],
  "fanModes": ["auto", "low", "med", "high", "turbo"],
  "swingModes": ["static", "swing", "top", "bottom"],
  "commands": {
    "off": "JgCSAAABI5QUNxQTFRMUExU2FTYVNxUSFTYVNhU3FBMUExYSFBMVEhUTFBMUFBQTFDcUNxU2FRMUExUTFBMUExU2FRMUNxQTFhIUNxUSFQACjhY2FBMUExUTFRIUExUUFBIUFBU2FRIVEhYSFTYUExUTFBQTExUTFBMUFBQTFBMUFBQTFBMVExQTFBQUExQ3FBMVAA0F",

SmartIR version
1.9.0

Thanks in advance

@litinoveweedle
Copy link
Owner

Hello, thank you for this. Will you be able to open PR for this? Or should I change it? I have no way to validate it, so your confirmation is welcome. Thank you.

@litinoveweedle litinoveweedle added enhancement New feature or request and removed potential bug labels Dec 5, 2024
@Itay1787
Copy link
Author

Hello, thank you for this. Will you be able to open PR for this? Or should I change it? I have no way to validate it, so your confirmation is welcome. Thank you.

Hey, sorry it took me so long to respond. I tried to open PR but had never done it before, so I didn't know what I was doing. if you can change it I will be the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants