Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info block horizontal Picture is to high #2488

Open
hello-kathi opened this issue Mar 15, 2022 · 6 comments
Open

Info block horizontal Picture is to high #2488

hello-kathi opened this issue Mar 15, 2022 · 6 comments

Comments

@hello-kathi
Copy link

URL: https://opin-dev.liqd.net/de/ambassadors/
user: admin
expected behaviour: Picture should be in Inline with the headline
behaviour: Picture is higher than the headline, so if more than one info block vertical is there it is too close to each block and the Link button is cut off
important screensize:
device & browser:
Comment/Question:

Screenshot?
Bildschirmfoto 2022-03-15 um 14 31 43
Bildschirmfoto 2022-03-15 um 14 31 30

@hello-kathi
Copy link
Author

@phillimorland are these two issues? That the bottom is cut off and that the blocks are too close or that the picture is too high?

@philli-m
Copy link
Contributor

philli-m commented Mar 15, 2022

@hello-kathi ok so the headline thing is actually an accessibility thing. The info blocks should be self contained information and should therefore have h2 headlines always, never h1 as they do not describe the page content and not h3 as they should be used within the block for sub headings, does that make sense?

here is a link to describe how headings should be used
https://accessibility.iu.edu/creating-content/web-content/headings.html

Link being cut off is a different issue

@hello-kathi
Copy link
Author

hello-kathi commented Mar 15, 2022

@phillimorland No not really. I cant change the headline/Title in the infoblock that is a fix box in wagtail. But maybe I wrote it wrong:
The Picture from the horizontal infoblock with no colour background (boxed, boxed variant) is ditching on the block above. The picture is not in the middle of the text block. Thats whats bother me, the headline can stay how it is.

@philli-m
Copy link
Contributor

@hello-kathi damm sorry!!! I thought they were added by richtext input, err this is one of those things that I could do a quick fix on or we go through and properly improve the structure as right now, it's not good.

@hello-kathi
Copy link
Author

@phillimorland ok I need a suggestion from you if a quick fix or improvement. I can't estimate how long which solution takes. If the improvement, and yes I think that would be the best option, block you for a longer time then we have to talk about.

@philli-m
Copy link
Contributor

@hello-kathi I think to go through and ensure the blocks are correctly structured for accessibility would be maybe 2-3 hours, and then testing and issues.
Quick fix i guess is 20 mins plus testing (hopefully no issues as it's a small, contained change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants