Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate parts README.md to CONTRIBUTING.md #59

Open
macobo opened this issue Aug 11, 2013 · 3 comments
Open

Separate parts README.md to CONTRIBUTING.md #59

macobo opened this issue Aug 11, 2013 · 3 comments

Comments

@macobo
Copy link
Contributor

macobo commented Aug 11, 2013

This should also include instructions on setting up development environment and running tests, coding style.

@lihaoyi
Copy link
Owner

lihaoyi commented Aug 12, 2013

Is there much to talk about, though? It's gonna be like "download from git - install using setup.py - run_tests.py to run tests"

@reem
Copy link

reem commented Nov 25, 2013

The source can be a bit hard to follow (though it is well commented). A short explanation of how the core of macropy works would be very useful to new contributors.

@lihaoyi
Copy link
Owner

lihaoyi commented Dec 17, 2013

Not-quite-core docs already exists in https://github.com/lihaoyi/macropy#reference, to the best of my abilities.

As for the core-core stuff, that's basically all in macropy/core, Apart from the fact that it uses import hooks and operates on Python ASTs, it is a reasonably standard data-processing application. There isn't any implicit structure (e.g. dependencies in mutable state) that isn't already encoded in the structure of the function calls.

That kind of structure isn't easy to read on github, but any decent IDE with jump-to-definition and find-usages will let you explore the shape of the program much better than I can write out in words, and those basically always work, since I don't do the functions-names-as-strings thing that you see in many other code bases. Exploring that structure will be much more useful than anything I can put down in words.

Best bet would be to open it up in PyCharm, start jumping around the code base, and sprinkle some print statements while running the "Hello World" examples to see how the macropy initializes and executes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants