Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Splicing] Make funding transaction available in funded channel #3300

Closed
optout21 opened this issue Sep 6, 2024 · 0 comments · Fixed by #3380
Closed

[Splicing] Make funding transaction available in funded channel #3300

optout21 opened this issue Sep 6, 2024 · 0 comments · Fixed by #3380

Comments

@optout21
Copy link
Contributor

optout21 commented Sep 6, 2024

This is is a relatively minor change preparation for splicing ( #1621 ).

The funding transaction is available in the ChannelContext::funding_transaction field. However, it is available only during channel negtiation, it is cleared afterwards.
In splicing, the funding transaction is needed later (for tx_add_input message).

Two possible approaches:

  1. Safe (less invasive), but ugly (redundant): duplicate funding_transaction field, set it at the same time, but don't clear it. This approach is used in [Early Draft] Splicing prototype #3274 (proto).
  2. Clean but risky: change the behavior that funding_transaction holds the transaction during the whole lifetime of the channel. The risk is that there might be code logic that relies on the field being cleared (which has to be found and adapted).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant