Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webrtc to logic of ping/rust #82

Closed
John-LittleBearLabs opened this issue Nov 23, 2022 · 2 comments
Closed

add webrtc to logic of ping/rust #82

John-LittleBearLabs opened this issue Nov 23, 2022 · 2 comments

Comments

@John-LittleBearLabs
Copy link

It should be possible to gain access to transports/webrtc in testplan_0500.rs
The goal here is to verify that one could get the test to switch from TCP to WebRTC, not to make sure the automated CI tests do so.

@mxinden
Copy link
Member

mxinden commented Nov 29, 2022

@John-LittleBearLabs would you mind opening a pull request with your changes as a draft? That way we might be able to help you and we can follow the progress.

Is there much more required than replacing the tcp here with webrtc?

std::net::IpAddr::V4(addr) => format!("/ip4/{addr}/tcp/{LISTENING_PORT}"),

Note that this will only work with rust-libp2p v0.50.0, which has been released last week.

@John-LittleBearLabs
Copy link
Author

would you mind opening a pull request with your changes as a draft?

#84

Is there much more required than replacing the tcp here with webrtc?

I do believe so. The existing test code doesn't even have the 'webrtc' cargo feature.

Note that this will only work with rust-libp2p v0.50.0, which has been released last week.

Yeah I've been testing in the master config, but knowing that it's been released I should be able to update to depend on the released version directly.

@p-shahi p-shahi linked a pull request Dec 1, 2022 that will close this issue
@p-shahi p-shahi closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants