-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass options to ldap operations #33
Comments
Hmm...i think we did that largely because it's a server setting that can't really be altered from the client, let me check what's what and i'll get back to you :) Only option that may be worth considering is the attributes one, but I didn't see the point at that time since you can easily filter it out whichever way you want it in js after getting the response. |
It sounds really weird if we aren't able to set the timeout. That siounds like a client option.. |
Actually LDAP can set for client and server some timelimit for there operation:
|
@ptusch Do you want to add other options or just timeLimit? Becouse the timeLimit is now merge into dev and I can close this issue. |
@cosminghitea |
@cosminghitea I couldn't find the use of an object in the development branch. |
Currently, we don't pass any options to ldap operations but that should be done.
One major issue is the timeout. This seems too be hardcoded on C.
Other options that should be passed are limit of results.
Maybe go to ldapjs and steal some ideas.
Having hardcoded timeouts actually breaks the benchmark :(
The text was updated successfully, but these errors were encountered: