Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup error message when database does not exist #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cleanup error message when database does not exist #6

wants to merge 2 commits into from

Conversation

nZac
Copy link
Contributor

@nZac nZac commented Oct 31, 2019

Fixes GH-5

@nZac nZac added the enhancement New feature or request label Oct 31, 2019
@nZac nZac requested a review from a team October 31, 2019 01:36
@nZac nZac self-assigned this Oct 31, 2019
@nZac nZac force-pushed the 5-cleanup-error-message branch 3 times, most recently from dda4c1e to d0a1626 Compare October 31, 2019 02:22
@nZac nZac force-pushed the 5-cleanup-error-message branch from d0a1626 to caf6b5b Compare October 31, 2019 02:31
@codecov
Copy link

codecov bot commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #6 into master will increase coverage by 0.95%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
+ Coverage   89.26%   90.21%   +0.95%     
==========================================
  Files          11       11              
  Lines         475      501      +26     
  Branches       37       37              
==========================================
+ Hits          424      452      +28     
  Misses         33       33              
+ Partials       18       16       -2
Impacted Files Coverage Δ
worek/dialects/postgres.py 83.45% <100%> (+0.74%) ⬆️
worek/core.py 62.5% <100%> (+16.66%) ⬆️
worek/tests/test_core.py 100% <100%> (ø) ⬆️
worek/cli.py 83.33% <50%> (-3.34%) ⬇️
worek/tests/conftest.py 94.87% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d2b7d...caf6b5b. Read the comment docs.

@nZac nZac removed their assignment Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw cleaner error message when database doesn't exist
1 participant
@nZac