Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionHandler: better "life cycle" handling for execution actions occurring sequentially in the same process #15

Open
rsyring opened this issue Aug 13, 2024 · 0 comments

Comments

@rsyring
Copy link
Member

rsyring commented Aug 13, 2024

B/c we catch all exceptions in on_action, we need to manually send the exception to Sentry before logging it and returning: https://docs.sentry.io/product/sentry-basics/integrate-backend/capturing-errors/

Probably doesn't apply since we are sending it manually, but should look closer at the code to see what it does: https://docs.sentry.io/platforms/python/integrations/aws-lambda/manual-instrumentation/

Also, flask has certain events that are issued during a web request and those are used to init & cleanup each request. We should do those same things (e.g. clear the db session) when calling any action on the handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant