-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentryMonitor Improvements #192
Comments
I also had to make some adjustments to our ping task in a client project based on error codes received from Sentry. It's possible we'd want to include those in this lib. I retried 503 errors (which Sentry seems to respond with intermittently). I also ignored 429 rate limiting errors. Edit: addressed by #193 |
Also looks like Sentry already has some cron functionality in the |
SentryMonitor.__init__
requires anenv
argument whileSentryMonitor.apply_config
assumesenv
from theSENTRY_ENVIRONMENT
in the app config. That behavior is inconsistent. If there's no reason for it, let's just make__init__
getenv
from the app config as well.It's also annoying to have to pass the
org
argument in everywhere. Can we make that default to an app config variable (if not force it to come from one, likeSENTRY_ENVIRONMENT
)?The text was updated successfully, but these errors were encountered: