-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend dynamically generated selectors (summary). #2200
Comments
Strictly speaking [2] is not even a "dynamically generated selector" but it's almost always mentioned with [1] examples so they are merged here for more easy tracking. (Though these two sub-features don't have to be implemented simultaneously). |
+1 |
When are this feature will done? It's great and very useful. |
I can imagine that this requires fundamental changes to some internals, but it should really be higher priority. 👍 |
Do we have an idea of what needs to be changed to support this? I'm more than willing to help out. |
It's just about adding the corresponding modifications to the extend implementation. |
Also, what about #1485? You mentioned it's a separate feature, but would the changes needed to make this work cover that use case as well? |
Honestly I'm not sure I understand the question. These are really three separate features from both usage and development perspective (neither one depends on the other and there's just a little overlapping between them from a technical point of view). |
Ahh, I see. I assumed that the two issues would share the same technical solution. Thanks for clearing that up. |
Is example 2 correctly written? I'm not sure why |
Indeed. Hello copy-paste. Fixed now. |
🆙 |
Can't wait for this feature to each LESS 3 ;) |
Hello everyone ! |
@guillaume-duchemin @seven-phases-max
|
This ticket is to replace (mostly for the sake of clear minimal examples):
#1325
#1539
#1597
It includes two distinct sub-features that require internal selector re-parsing:
[1]. Extend interpolated selector:
Expected result:
[2]. Extend concatenated selector:
Expected result:
Related but pretty much independent feature of using a variable as an
extend
argument,i.e.
:extend(@{var})
, is clearly specified in #1485 and not included here.The text was updated successfully, but these errors were encountered: