Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update _last_lr in step() #3

Open
seungyonglee0802 opened this issue Oct 4, 2023 · 0 comments
Open

update _last_lr in step() #3

seungyonglee0802 opened this issue Oct 4, 2023 · 0 comments

Comments

@seungyonglee0802
Copy link

First of all, thanks for your nice implementation of Warmup wrapper.

I found one tiny thing to improve.

By adding self._last_lr = [group["lr"] for group in self.optimizer.param_groups] at the end of step() function, we could get right value of lr when we call scheduler.get_last_lr()[0] to check lr value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant