band_interleave hydro_dump

[liangwang0734]

Hi,

This is a new user question: In src/vpic/dump.cc, the band_interleave branch of hydro_dump seems to not correctly set the dim array to include ghost layer:

    dim[0] = nxout;
    dim[1] = nyout;
    dim[2] = nzout;

while the field_dump does

    dim[0] = nxout+2;
    dim[1] = nyout+2;
    dim[2] = nzout+2;

It appears to me that the two extra cells are ghost cells. For direct dump (no stride), I believe the dim array should include them, since the memory block is dumped as a whole.

Thanks,
Liang

PS:

• Commit I am working on (current master as of 11/01/2017): 91a209d
• Link to file: https://github.com/lanl/vpic/blob/91a209d68f8d0fa8b58c7201dd0411a3fcb57e3e/src/vpic/dump.cc

[rfbird]

Hey,

Sorry for the slow reply on this. It does look like this may be an issue. We're trying to figure out if changing this would have any other wide spread problems associated with it

Best,
Bob