Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importOSMeasure error when valid inputs are choices taken from os model #726

Open
Larry7707 opened this issue Jul 9, 2019 · 0 comments
Open

Comments

@Larry7707
Copy link
Contributor

This is basically a followup for issue #724. When importing ReduceSpaceInfiltrationByPercentage, the first input _ApplytheMeasuretoaSpecificTypeortotheEntireModel is to choose a space type to apply the measure. When validating the inputs, the valid values taken from the xml file is a GUID in a curly bracket, which will lead a warning for invalid input and throw an error because of input being None. This is the reason for the breakdown in Elliot's follow-up post. Similar bugs will also occur in several other measures where the valid values for inputs are GUIDs. I feel like it is hard to fix this perfectly, so maybe it is possible to just detect when GUID is used and assign the value to the inputs anyway even if it is invalid to prevent such breakdown. I can help to fix it if you want. Let me know how it goes. Thanks!

@Larry7707 Larry7707 changed the title importOSMeasure error when valid inputs are choices taken from .osm importOSMeasure error when valid inputs are choices taken from os model Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants