Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate inputs for subscription destinations #417

Open
demeyerthom opened this issue Aug 21, 2023 · 1 comment
Open

Validate inputs for subscription destinations #417

demeyerthom opened this issue Aug 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@demeyerthom
Copy link
Member

We currently don't check for additionally set fields when processing an update to a subscription. When fields are set that are not used for an update (for example region on an SNS destination) the provider breaks after apply because its new state is inconsistent with its expected state.

We should validate these inputs up front, and throw an error when fields are set that are not expected by the destination.
@demeyerthom demeyerthom added the bug Something isn't working label Aug 21, 2023
@demeyerthom
Copy link
Member Author

Should fix bugs like #355

@demeyerthom demeyerthom added enhancement New feature or request and removed bug Something isn't working labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@demeyerthom